Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cors)!: doesn't return access-control-allow-origin header when origin is disallowed #870

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aaharu
Copy link
Member

@aaharu aaharu commented Aug 26, 2024

resolves #355

@aaharu aaharu requested a review from pi0 as a code owner August 26, 2024 09:16
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (a58d7c9) to head (d476c72).
Report is 190 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   77.83%   79.46%   +1.63%     
==========================================
  Files          47       43       -4     
  Lines        4286     3292     -994     
  Branches      611      798     +187     
==========================================
- Hits         3336     2616     -720     
+ Misses        933      673     -260     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Aug 29, 2024

Can you please add a regression test?

@aaharu
Copy link
Member Author

aaharu commented Sep 17, 2024

It's going to be a conflict, so I'll work on it after #856.

@aaharu aaharu changed the title fix(cors): fix acao header fix(cors)!: doesn't return access-control-allow-origin header when dynamic Oct 4, 2024
@aaharu aaharu changed the title fix(cors)!: doesn't return access-control-allow-origin header when dynamic fix(cors)!: doesn't return access-control-allow-origin header when origin is disallowed Oct 4, 2024
@aaharu
Copy link
Member Author

aaharu commented Oct 7, 2024

IMO, Access-Control-Allow-Origin: null doesn't need to be supported.
Because it should not be used.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Origin#null

@aaharu aaharu marked this pull request as draft October 11, 2024 04:16
@aaharu aaharu marked this pull request as ready for review October 11, 2024 11:50
@pi0 pi0 added the v2 label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS issue in creating origin headers
2 participants