Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session): allow replace instead of update #774

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

remonke
Copy link
Contributor

@remonke remonke commented Jun 14, 2024

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (a58d7c9) to head (4b630ea).
Report is 190 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/session.ts 81.81% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
+ Coverage   77.83%   79.78%   +1.95%     
==========================================
  Files          47       53       +6     
  Lines        4286     5324    +1038     
  Branches      611      676      +65     
==========================================
+ Hits         3336     4248     +912     
- Misses        933     1058     +125     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0 pi0 changed the title feat: add replaceSession function feat(session): allow replace instead of update Jun 17, 2024
@pi0
Copy link
Member

pi0 commented Jun 17, 2024

Thanks for the PR. I think instead of introducing a new replaceSession method, we can introduce a new 3rd arg replace: true to allow replacing it.

@pi0 pi0 marked this pull request as draft June 17, 2024 12:17
@pi0 pi0 added the v2 label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants