Consider 4xx and 5xx status as error instead of trying to render MD #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -14,6 +14,7 @@ export default Route( | |||
| <div style="border: 1px solid red; padding: 1rem;"> | |||
| {{error}} | |||
| </div> | |||
| {{(removeLoader)}} | |||
There was a problem hiding this comment.
this makes sense, thanks!
NullVoxPopuli
force-pushed
the
utilize-routes
branch
2 times, most recently
from
77fe7a8
to
92a0424
Compare
rtablada
force-pushed
the
error-response
branch
3 times, most recently
from
d5393da
to
2a12528
Compare
NullVoxPopuli
force-pushed
the
error-response
branch
from
2a12528
to
536a5ab
Compare
There was a problem hiding this comment.
derivation intensifies!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation RemoteData will only error if the underlying JSON parse is unsuccessful on
jsonheader responses.There are cases where a static server may serve up 4xx/5xx responses and send invalid MD files that could even be insecure content.
This chance is reduced by the
utilize-routeschanges, but is still possible if a user keeps the docs open and a page is moved/deleted thus causing the server to send invalid MD (in the case of GH pages or S3 static site defaults 404 requests will send the index HTML which likely is not valid to try and parse/render).