Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize routes to better manage error redirection and page loading #82

Closed
wants to merge 6 commits into from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 28, 2024

Compilation is pretty fast once we have the page.

Note that the description here: emberjs/ember.js#20712 may be a better-written counter-argument for using routes (as they exist in today's ember, anyway)

@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Jun 28, 2024
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kolay-docs-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 0:01am

@NullVoxPopuli
Copy link
Contributor Author

Not going to pursue this due to perceived behavior emberjs/ember.js#20712 (comment)

@NullVoxPopuli NullVoxPopuli deleted the utilize-routes branch July 5, 2024 19:45
/**
* Configuration for what to do when certain events happen.
*/
on?: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these events may still be valuable though!

but they don't have to be implemented via the routing system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant