-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize routes to better manage error redirection and page loading #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NullVoxPopuli
force-pushed
the
utilize-routes
branch
from
June 30, 2024 00:16
a23afbf
to
77fe7a8
Compare
NullVoxPopuli
force-pushed
the
utilize-routes
branch
from
June 30, 2024 00:34
77fe7a8
to
92a0424
Compare
NullVoxPopuli
added a commit
that referenced
this pull request
Jul 3, 2024
NullVoxPopuli
added a commit
that referenced
this pull request
Jul 3, 2024
Fix app watching -- Copy content from #82
NullVoxPopuli
force-pushed
the
utilize-routes
branch
from
July 3, 2024 23:58
d4ad716
to
ee55216
Compare
Merged
Not going to pursue this due to perceived behavior emberjs/ember.js#20712 (comment) |
NullVoxPopuli
commented
Jul 5, 2024
/** | ||
* Configuration for what to do when certain events happen. | ||
*/ | ||
on?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these events may still be valuable though!
but they don't have to be implemented via the routing system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation is pretty fast once we have the page.
Note that the description here: emberjs/ember.js#20712 may be a better-written counter-argument for using routes (as they exist in today's ember, anyway)