Skip to content

Conversation

jafl
Copy link
Contributor

@jafl jafl commented Oct 9, 2025

Support for properties:static, like what I added to the JavaScript parser

@jafl jafl requested a review from masatake October 9, 2025 04:33
@jafl jafl self-assigned this Oct 9, 2025
int curlyLevel;
} blockState;

static fieldDefinition sFields[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a variable so TsFields is better than sFields.

@jafl jafl force-pushed the typescript-static-property branch from 3ddce4b to 21987b4 Compare October 9, 2025 06:30
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (0644fb8) to head (21987b4).
⚠️ Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
parsers/typescript.c 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4311      +/-   ##
==========================================
- Coverage   85.96%   85.87%   -0.09%     
==========================================
  Files         246      248       +2     
  Lines       63463    63620     +157     
==========================================
+ Hits        54555    54636      +81     
- Misses       8908     8984      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masatake
Copy link
Member

masatake commented Oct 9, 2025

I'll merge after finishing #4271.

@jafl could you add

	def->versionCurrent = 1;
	def->versionAge = 1;

As you did in jscript.c?

@masatake
Copy link
Member

masatake commented Oct 9, 2025

commit 21987b47333cd2dfc608f32a00e131f0f8ad9185 (HEAD -> typescript-static-property)
Author: John Lindal <[email protected]>
Date:   Wed Oct 8 21:32:18 2025 -0700

    TypeScript: support for "properties:static"

commit 0644fb80a8250cc3ca6ba00037e490768fe4492e (tag: p6.2.20250615.0)

Your change based on too old source tree.
Could you do something like:

git checkout master
git pull upstream master:master
git checkout typescript-static-property
git rebase master
git push --force origin typescript-static-property

@jafl
Copy link
Contributor Author

jafl commented Oct 9, 2025

I need to open a new PR, because I rebased.

@masatake
Copy link
Member

masatake commented Oct 9, 2025

(You can use push --force just after rebasing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants