-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ModernBERT config #119
base: master
Are you sure you want to change the base?
Conversation
Currently the modernbert forward pass gives NaN outputs:
Edit: Seems to be fixed after installing flash attention |
} | ||
}, | ||
"optimizer": { | ||
"type": "Adam", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth using the hyperparameters given here:
https://github.com/AnswerDotAI/ModernBERT/blob/main/examples/finetune_modernbert_on_glue.ipynb
"optimizer": {
"type": "AdamW",
"args": {
"lr": 8e-5,
"weight_decay": 8e-6,
"betas": [0.9, 0.98],
"eps": 1e-6,
"amsgrad": false
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! would be good to have something about the benefits of modernbert in the description too
Adds a ModernBERT config for the original toxic comment classification challenge, using the ModernBERT-base model.
Currently requires installing transformers from git to train: huggingface/transformers#35362 (comment)