-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download NCBI Taxdmp file in CI #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Can you update the build_database
-script accordingly such that it uses our mirrored version of the taxon dump? Ideally the script should check if our "mirrored version" is available, and automatically fallback to the old URL if not.
Will do. I didn't do it yet in this PR because the very first time the file will not exist, but using the default as a fallback is a good idea and fixes that problem as well. |
Very ironically showing that this is already a good change, NCBI just changed their endpoint and the original download URL no longer works. I've updated the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This code looks great as well :) I'll start the run to create a new version of the static database (and upload our new taxon file) right now.
We discussed adding this file to the automatic releases because it is sometimes arbitrarily slow to download