Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Create application with name from kraft.yaml #83

Closed
gabrielmocanu opened this issue Oct 30, 2021 · 2 comments
Closed

Create application with name from kraft.yaml #83

gabrielmocanu opened this issue Oct 30, 2021 · 2 comments
Assignees

Comments

@gabrielmocanu
Copy link
Member

Describe the bug
Right now when you build an application it will use the name convention from the parent directory of that application, instead of using the name from kraft.yaml. This bug also caused this problem #80 .

To Reproduce
Steps to reproduce the behavior:
[email protected]:unikraft/app-helloworld.git
2. cd app-helloworold
3. kraft configure -p kvm -m x86_64
4. kraft build

Expected behavior
After building an application with the name example from kraft.yaml, the unikernel executable should have the name example_kvm-x86-64 even though the parent directory where this application has a different name.

Screenshots
Screenshot from 2021-10-30 13-56-53

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version 20.10

Additional context

@gabrielmocanu
Copy link
Member Author

@StefanJum

Can this issue be closed since this PR was merged?

@StefanJum
Copy link
Member

@StefanJum

Can this issue be closed since this PR was merged?

Yes, we should close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants