Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Kraft failes with list index out of range #80

Closed
gabrielmocanu opened this issue Oct 30, 2021 · 5 comments
Closed

Kraft failes with list index out of range #80

gabrielmocanu opened this issue Oct 30, 2021 · 5 comments
Assignees

Comments

@gabrielmocanu
Copy link
Member

Describe the bug
Right now if you are trying to run the hello-world application you will end up with list index out of range error. This can be for all applications if the name of the directory of the application is different from the name of the application from kraft.yml.

To Reproduce
Steps to reproduce the behavior:

  1. git clone [email protected]:unikraft/app-helloworld.git
  2. cd app-helloworld
  3. kraft configure -p kvm -m x86_64
  4. kraft build
  5. kraft run

Expected behavior
The error is not descriptive at all, it is more of a python error than something suggestive so you can figure out what to do with kraft. From my point of view, it would be better to suggest to you that kraft doesn't find the executable.

Screenshots
Screenshot from 2021-10-30 10-38-11

Desktop (please complete the following information):

  • OS: Ubuntu

Additional context

@gabrielmocanu
Copy link
Member Author

After creating the pull request I was thinking also of something else.
Why don't kraft build create by default the unikernel executable as the naming convention from kraft.yaml.

So for example:
If we have app-A, after kraft build we will have the unikernel executable app-A_x86-64, even though in the kraft.yaml file we have the application name only 'A'. I think it's better to use only the notations from kraft.yml.
Is there any consideration of using the directory name of the application for unikernel executable name?

@gabrielmocanu
Copy link
Member Author

I create another issue for what I told you before.(#83)
But I think the PR from this issue is still relevant because it basically treats a possible error there.

@xymeng16
Copy link
Contributor

#73 is also related to this issue.

xymeng16 added a commit to xymeng16/kraft that referenced this issue Jan 22, 2022
razvand pushed a commit that referenced this issue Mar 17, 2022
@gabrielmocanu
Copy link
Member Author

@StefanJum

Can this issue be closed since this PR was merged?

@StefanJum
Copy link
Member

@StefanJum

Can this issue be closed since this PR was merged?

Yes, I think it should be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants