Add binary file output support #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Port of embedded-gcov[1] for Unikraft. [1] https://github.com/nasa-jpl/embedded-gcov Signed-off-by: Michalis Pappas <[email protected]>
michpappas
requested changes
Mar 31, 2023
There was a problem hiding this comment.
Nice! 😎 I have left inline comments on some minor issues.
One more thing that could be imporoved is the structure of the README with a brief summary of the process before elaborating on the individual output types, ie something along the lines of:
- Patch code to add
__gcov_exit() - Select output type and build
- Run script (a brief description of what the script does and sample output can be added here)
Also I noticed some trailing whitespace here and there. You can spot them with git show.
Starnox
added a commit
to Starnox/unikraft-lib-embedded-gcov
that referenced
this pull request
Apr 6, 2023
- Improved README - Added 'used' attribute in gcov patch Signed-off-by: Eduard-Florin Mihailescu <[email protected]>
michpappas
reviewed
Apr 10, 2023
michpappas
requested changes
Apr 10, 2023
There was a problem hiding this comment.
@Starnox thanks for updating this PR. Besides the rest of the comments, please:
- Rebase on top of Introduce lib-embedded-gcov #1. If we can get it merged before the next iteration of this PR, even better (you are a reviewer and @razvand is the approver).
- Squash 8f0bc5f into d6e5d23.
Thanks!
Starnox
force-pushed
the
add-binary-file-output
branch
2 times, most recently
from
edfcaf8
to
2c3a9b6
Compare
- Added configuration options to accommodate the feature. - Added patch for the embedded-gcov library to resolve division bug - Included helper script for processing extracted information - Modified README Signed-off-by: Eduard-Florin Mihailescu <[email protected]>
Starnox
force-pushed
the
add-binary-file-output
branch
from
2c3a9b6
to
9ea34c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for binary file coverage information, based on #1
embedded-gcovlibrary that fixes a minor bug in the way divisions were madeREADME.md