feat(workflows): Enable code spellchecking #947
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craciunoiuc
added
kind/enhancement
|
Thanks 😇 But is this not already enabled via golangci-lint ? |
craciunoiuc
force-pushed
the
craciunoiuc/enable-spellcheck
branch
2 times, most recently
from
d95497b
to
c9f5265
Compare
Signed-off-by: Cezar Craciunoiu <[email protected]>
craciunoiuc
force-pushed
the
craciunoiuc/enable-spellcheck
branch
from
c9f5265
to
141be6b
Compare
|
I think that is for variables only? Comments are for sure ommited. Anyways, this is just an idea right now, they don't really say how this should be structured so I just tried some things |
|
Converting to draft cause it doesn't really work, also is not that urgent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This one is for you @nderjung
If we want this to work properly we need to add some custom dictionaries to make sure that words like
unikraftandkraftkit, etc. are caughtWe can add single exceptions, but I think it warrants a dictionary. Examples:
https://github.com/check-spelling/check-spelling/wiki/Feature:-Area-dictionaries
We should not merge until then