Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows): Deprecate sentry/action-release #2178

Conversation

nderjung
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

Copy link
Member

@craciunoiuc craciunoiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here. Thanks!

Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]

It is not compatible with the checkout action version[0].
Anyway the release version is embedded into the relevant
binaries.

[0]: getsentry/action-release#209

Signed-off-by: Alexander Jung <[email protected]>
@nderjung nderjung force-pushed the nderjung/fix/workflows/deprecate-sentry-release branch from 7f37303 to cf659fd Compare February 18, 2025 16:35
@craciunoiuc craciunoiuc merged commit 23bd62b into unikraft:staging Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants