Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloud): Add changes to allow switching to different OSes #1832

Merged

Conversation

craciunoiuc
Copy link
Member

@nderjung do not merge until we get the good to go

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc craciunoiuc requested a review from nderjung August 6, 2024 08:53
@craciunoiuc craciunoiuc marked this pull request as draft August 6, 2024 08:53
@craciunoiuc craciunoiuc marked this pull request as ready for review November 12, 2024 12:22
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/volimport-arg-updates branch from 2eb22a2 to b85f094 Compare December 18, 2024 16:06
@craciunoiuc
Copy link
Member Author

@mogasergiu

Copy link
Member

@mogasergiu mogasergiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-by: Sergiu Moga [email protected]

internal/cli/kraft/cloud/tunnel/tunnel.go Outdated Show resolved Hide resolved
internal/cli/kraft/cloud/volume/import/import.go Outdated Show resolved Hide resolved
This allows for the tunnel and volimport images to still be present
for a while, while the switched to versioned images happens.

Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/volimport-arg-updates branch from b85f094 to beb5aa2 Compare December 19, 2024 15:26
@craciunoiuc craciunoiuc requested a review from nderjung December 19, 2024 16:01
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nderjung nderjung merged commit 95e2a12 into unikraft:staging Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants