fix(arm): correct write to ARM coprocessor #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like commenting out by accident? Btw, you should target dev branch. |
This code was commented out since 2021, but by default, the error codewas initialized to `UC_REG_OK`, so there was no error returned untila result, any write to `UC_ARM_REG_C1_C0_2` returned an error.
amaanq
force-pushed
the
arm-coprocessor-write
branch
from
6233b76 to
952794c
Compare
|
Done, thanks |
|
Will merge after I get CI fixed. Please wait a bit. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Any attempt to write to UC_ARM_REG_C1_C0_2 (The ARM Coprocessor Access Control Register) fails with UC_ERR_ARG.
The specific switch case handling writes to this register was commented out since 2021, but by default, the error code was initialized to UC_REG_OK, so there was no error returned until #1835, where this was changed to be initialized to UC_REG_ERR_ARG. As a result, any write to UC_ARM_REG_C1_C0_2 returned an error.
Solution
In this PR, I've uncommented and properly implement the CPACR register write with appropriate size checking. I've also added a unit test to verify that writes no longer fail - before this PR, the test does indeed fail.