arm64 python: Avoid nested class in insn hook for 10x hook and 10% overall speedup #2095
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote CpReg to a module-level class to address unnecessary performance reduction. In a real-world use case tracing the emulation of real-world machine code, this change reduces time spent in CpReg namedtuple construction from 10% of overall time to below 1%, for a 10x speedup of the insn hook itself, or a 10% overall speedup. Measured using cProfile, python 3.13.
|
Build failures look unrelated to this change. |
|
No idea why it suddenly fails. Let me rerun it firstly. |
|
Failures still look unrelated to this PR. Similar failures also happen in other PR branches. Also, it looks like GCC is crashing, and I'd be very surprised if this Python-only change would cause a GCC crash. |
|
The crashes result from Github Action upgrading default ubuntu distribution (kernel upgrades). It does not relate to your changes and I just lack time to fix it. Please wait a bit sorry.
…________________________________
From: Daniel Roethlisberger ***@***.***>
Sent: Sunday, February 2, 2025 3:41:36 AM
To: unicorn-engine/unicorn ***@***.***>
Cc: lazymio ***@***.***>; Comment ***@***.***>
Subject: Re: [unicorn-engine/unicorn] arm64 python: Avoid nested class in insn hook for 10x hook and 10% overall speedup (PR #2095)
Failures still look unrelated to this PR. Similar failures also happen in other PR branches. Also, it looks like GCC is crashing, and I'd be very surprised if this Python-only change would cause a GCC crash.
―
Reply to this email directly, view it on GitHub<#2095 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJULO5ZNU22OCBCDBTIFSL2NUPPBAVCNFSM6AAAAABV3W2OF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZGA4DKMBZHE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote CpReg to a module-level class to address unnecessary performance reduction.
In a real-world use case tracing the emulation of real-world machine code, this change reduces time spent in CpReg namedtuple construction from 10% of overall time to below 1%, a ~ 10x speedup of the insn hook itself, or a ~ 10% overall speedup. Measured using cProfile, python 3.13.