AstronomicalSimulation -> ReingoldSimulation
#7342
Conversation
robertbastian
force-pushed
the
simulated
branch
2 times, most recently
from
99cd652 to
5ea69c0
Compare
sffc
left a comment
sffc
left a comment
There was a problem hiding this comment.
I think this direction is consistent with #7340, since it takes advantage of the bullet point "We decide to tweak the precise astronomical simulation used" and keeps the type AstronomicalSimulation as representing an astronomical simulation, just a different one than we had been shipping before.
| Ok(AnyCalendarKind::HijriTabularTypeIIFriday) | ||
| } | ||
| Hijri(Some(HijriCalendarAlgorithm::Rgsa)) => Ok(AnyCalendarKind::HijriSimulatedMecca), | ||
| Hijri(Some(HijriCalendarAlgorithm::Rgsa)) => Err(()), |
There was a problem hiding this comment.
We don't return Err elsewhere in this fn; what is the impact?
There was a problem hiding this comment.
yes we do, for -u-ca-islamic
robertbastian
force-pushed
the
simulated
branch
from
1083fa9 to
5652bd5
Compare
robertbastian
requested review from
Manishearth and
zbraniecki
as code owners
Co-authored-by: Manish Goregaokar <[email protected]>
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
In favor of the technical implementation here.
Exact future for calendars still seems to be in flux, I am personally in favor of this being a component of most paths forward (potentially paired with some deprecation), but see #7320
3 participants
No description provided.