Skip to content

ICU-23209 Don't load standard patterns by default in DTPG #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ICU-23209 Don't load standard patterns by default in DTPG #3641

wants to merge 5 commits into from
+15 −4

Conversation

@sffc
Copy link
Member

@sffc sffc commented Sep 10, 2025 •
edited
Loading

This makes DTPG consider only availableFormats instead of standard patterns.

Checklist

  • Required: Issue filed: ICU-23209
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@sffc sffc force-pushed the CLDR-18881-patterns branch from 3d8a5c5 to bf67c38 Compare September 10, 2025 21:30
@jira-pull-request-webhook
Copy link

jira-pull-request-webhook bot commented Sep 10, 2025

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/DateTimeGeneratorTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

sffc added 4 commits September 10, 2025 16:20
@sffc
Update code
43f9616
@sffc
Update test expectation
b779baa 
The full datetime pattern is: "EEEE, d MMMM, y G"

There is no availableFormats match in the locale "ha", so we use the one from root instead.
@sffc
Update test expectation
c23d392 
If this seems odd, I have ICU-23210 to investigate further.
@sffc
Update the newly added test
75fa7ae
@sffc sffc changed the title CLDR-18881 Add test illustrating current behavior CLDR-18881 Don't load standard patterns by default in DTPG Sep 11, 2025
@sffc sffc changed the title CLDR-18881 Don't load standard patterns by default in DTPG ICU-23209 Don't load standard patterns by default in DTPG Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sffc