Skip to content

ICU-23092 u_getIntPropertyMaxValue(UCHAR_INDIC_CONJUNCT_BREAK) returns valid max value #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23092 u_getIntPropertyMaxValue(UCHAR_INDIC_CONJUNCT_BREAK) returns valid max value #3457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion icu4c/source/common/uchar_props_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4257,6 +4257,6 @@ static const UCPTrie block_trie={
0x0,
};

static const int32_t indexes[UPROPS_INDEX_COUNT]={0x2e8e,0x2e8e,0x2e8e,0x2e8e,0x6db4,3,0x86ce,0x87d5,0x8f67,0x8f67,0x50cf,0x2f75a31,0x152,0,0,0};
static const int32_t indexes[UPROPS_INDEX_COUNT]={0x2e8e,0x2e8e,0x2e8e,0x2e8e,0x6db4,3,0x86ce,0x87d5,0x8f67,0x8f67,0x1d0cf,0x2f75a31,0x152,0,0,0};

#endif // INCLUDED_FROM_UCHAR_C
9 changes: 9 additions & 0 deletions icu4c/source/common/unicode/uchar.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2763,6 +2763,15 @@ typedef enum UIndicConjunctBreak {
U_INCB_EXTEND,
/** @draft ICU 76 */
U_INCB_LINKER,
#ifndef U_HIDE_DEPRECATED_API
/**
* One more than the highest normal UIndicConjunctBreak value.
* The highest value is available via u_getIntPropertyMaxValue(UCHAR_INDIC_CONJUNCT_BREAK).
*
* @deprecated ICU 58 The numeric value may change over time, see ICU ticket #12420.
*/
U_INCB_COUNT
#endif // U_HIDE_DEPRECATED_API
} UIndicConjunctBreak;
#endif // U_HIDE_DRAFT_API

Expand Down
Binary file modified icu4c/source/data/in/uprops.icu
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions icu4c/source/test/cintltst/cucdtst.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2915,6 +2915,9 @@ TestAdditionalProperties(void) {
if( u_getIntPropertyMaxValue(UCHAR_EAST_ASIAN_WIDTH) != (int32_t) (U_EA_COUNT -1)) {
log_err("error: u_getIntPropertyMaxValue(UCHAR_EAST_ASIAN_WIDTH) wrong\n");
}
if( u_getIntPropertyMaxValue(UCHAR_INDIC_CONJUNCT_BREAK) != (int32_t) (U_INCB_COUNT -1)) {
log_err("error: u_getIntPropertyMaxValue(UCHAR_INDIC_CONJUNCT_BREAK) wrong\n");
}

/* test u_hasBinaryProperty() and u_getIntPropertyValue() */
for(i=0; i<UPRV_LENGTHOF(props); ++i) {
Expand Down
1 change: 1 addition & 0 deletions tools/unicode/c/genprops/corepropsbuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,6 +965,7 @@ CorePropsBuilder::build(UErrorCode &errorCode) {
totalSize=4*offset;

indexes[UPROPS_MAX_VALUES_INDEX]=
(((int32_t)U_INCB_COUNT-1)<<UPROPS_INCB_SHIFT)|
(((int32_t)U_EA_COUNT-1)<<UPROPS_EA_SHIFT)|
((int32_t)USCRIPT_CODE_LIMIT-1);
indexes[UPROPS_MAX_VALUES_2_INDEX]=
Expand Down
Loading