-
-
Notifications
You must be signed in to change notification settings - Fork 832
ICU-22789 Add Segmenter API to conveniently wrap BreakIterator in ICU4J #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One quibble.
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
Actually, one other observation. As things stand, |
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/Segment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late review!
so far i have mostly checked the API here against the proposal -- and found that the proposal omitted one method, see the design doc.
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed new feedback from @markusicu. PTAL.
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/Segment.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImplUtils.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImplUtils.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentSpliterator.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentIterator.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/LocalizedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/LocalizedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/LocalizedSegmenter.java
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/LocalizedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/LocalizedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundarySpliterator.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/Segmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/RuleBasedSegmenter.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/LocalizedSegmenterTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImpl.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImpl.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImpl.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/SegmentsImpl.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/SegmentsTest.java
Outdated
Show resolved
Hide resolved
icu4j/main/core/src/test/java/com/ibm/icu/dev/test/segmenter/RuleBasedSegmenterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lean and mean :-)
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
icu4j/main/core/src/main/java/com/ibm/icu/segmenter/BoundaryIteratorOfInts.java
Show resolved
Hide resolved
b51b630 to
21e00d9
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
In order to "modernize" the
BreakIteratorAPI, this PR introduces a new wrapper using a more convenient, modern API design around aSegmenterinterface.A few of the goals that motivate the new
SegmenterAPI:StreamAPI which underlies a functional programming styleMore details in the design doc.
This PR will focus on the ICU4J side of the work.
Checklist