Reclassifying ERRORS in data generation - see issue #238 #525

sven-oly · 2025-09-05T01:02:12Z

Old issue that should be completed.

gemini-code-assist

Summary of Changes

Hello @sven-oly, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #238 by refining the logging behavior within the data generation process. The primary goal is to improve the clarity and accuracy of log messages by distinguishing between actual critical errors and less severe configuration-related issues, thereby making it easier to identify and prioritize problems.

Highlights

Logging Level Adjustment: Changed logging.error to logging.warning in datetime_fmt.py, list_fmt.py, and relativedatetime_fmt.py for cases where the ICU version is not configured. This reclassifies these events from critical errors to less severe warnings, reflecting their non-blocking nature.
Log Message Refinement: Updated the log message in base.py's readFile function to be more concise and descriptive, changing "** READ: Error = %s" to "** readFile: %s".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request primarily reclassifies several logging calls from error to warning within the data generation scripts. This change seems appropriate for handling non-blocking issues, such as missing configurations for specific ICU versions. Additionally, a log message in base.py has been updated for better clarity. My review includes one significant point of feedback regarding exception handling in base.py, which could improve the robustness of the code.

testgen/generators/base.py

sven-oly · 2025-09-24T23:04:28Z

Please take a look.

sffc · 2025-09-24T23:48:05Z

testgen/generators/base.py

            try:
                test_no_label = test.copy()
-            except BaseException as error:
+            except BaseException as error:b'/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:9:main/core/src/test/java/com/ibm/icu/dev/test/timezone/TimeZoneTest.java:205:                } else if (!(referenceZone.getID().equals("ART") && logKnownIssue("ICU-22436", "Wrong DST status for time zone ART"))) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:10:main/core/src/test/java/com/ibm/icu/dev/test/calendar/CalendarTestFmwk.java:263:                if (cal.getType().equals("hebrew") && greg.get(Calendar.YEAR)>2500 && logKnownIssue("ICU-22441", "Hebrew calendar illegal year length")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:11:main/core/src/test/java/com/ibm/icu/dev/test/calendar/IBMCalendarTest.java:273:        if (!logKnownIssue("ICU-22924", "wbl-Arab returns wrong first day of the week, probably caused by wrong Likely Subtag algo")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:12:main/core/src/test/java/com/ibm/icu/dev/test/calendar/IBMCalendarTest.java:2289:                    logKnownIssue("ICU-22230", "Problem December in Leap Year");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:13:main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:895:                    logKnownIssue("ICU-23185", "Date time formatting with hz and hv needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:14:main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:900:                    logKnownIssue("ICU-23185", "Date time formatting with hz and hv needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:15:main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:1839:                    if (logKnownIssue("ICU-11585", "incompatible pattern between date format and date interval format")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:16:main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:2585:                logKnownIssue("CLDR-18923", "Quoting in scn atTime/relative dateTimeFormats causes format/parse issues");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:17:main/core/src/test/java/com/ibm/icu/dev/test/format/IntlTestDateFormat.java:272:                    logKnownIssue("CLDR-18923", "Quoting in scn atTime/relative dateTimeFormats causes format/parse issues");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:18:main/core/src/test/java/com/ibm/icu/dev/test/format/PersonNameConsistencyTest.java:89:                logKnownIssue(knownIssue, "Exception thrown on " + filename + ": " + e.toString());\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:19:main/core/src/test/java/com/ibm/icu/dev/test/format/PersonNameConsistencyTest.java:99:                logKnownIssue(knownIssue, "Failure in " + filename + ": Found " + errors + " errors.");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:20:main/core/src/test/java/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java:61:            if (!locale.getBaseName().startsWith("ks_Deva") || !logKnownIssue("22099", "locale-specific parse sets not supported")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:21:main/core/src/test/java/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java:64:            if (!locale.getBaseName().startsWith("nqo") || !logKnownIssue("CLDR-17023", "Number symbols and/or parseLenients messed up for N\xe2\x80\x99Ko")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:22:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:25:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:23:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:37:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:24:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:38:        uki.logKnownIssue("d/e/f", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:25:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:39:        uki.logKnownIssue("g/h/i", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:26:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:54:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:27:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:55:        uki.logKnownIssue("d/e/f", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:28:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:56:        uki.logKnownIssue("g/h/i", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:29:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:70:        uki.logKnownIssue("a/b/c", "21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:30:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:82:        uki.logKnownIssue("a/b/c", "zzz", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:31:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:94:        uki.logKnownIssue("a/b/c", "CLDR-9787", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:32:main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:106:        uki.logKnownIssue("a/b/c", "cldrbug:9787", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:40:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:564:            if (logKnownIssue("10494", "PluralRules is not serializable")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:41:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:580:            if (logKnownIssue("10494", "PluralRules is not de-serializable")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:42:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:707:        if (!logKnownIssue("ICU-23188", "Compact number formatting for ar-EG adds extra RLM")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:43:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:252:        if (!logKnownIssue("CLDR-18905", "German narrow change needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:44:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:262:        if (!logKnownIssue("CLDR-18905", "German narrow change needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:45:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:535:                    logKnownIssue("CLDR-18905", "German narrow change needs revisiting")\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:46:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:1593:            //\tlogKnownIssue("ICU-22781", "Handle concentr/perbillion in ICU");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:47:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberFormatTest.java:5562:        if (logKnownIssue("12045", "XSU is missing from fr")) { return; }\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:48:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberFormatTest.java:7173:            //    logKnownIssue("CLDR-18274", "The data for portion-per-XYZ is not determined yet.");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:49:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/PluralRulesTest.java:1169:                        logKnownIssue("10783", "Fix issues with isLimited vs computeLimited on ordinals");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:50:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:147:            if (logKnownIssue("CLDR-18924", "Timezone round trip issues in ku, shn, sv for various zones") &&\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:51:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:415:                \tif (logKnownIssue("CLDR-18924", "Time round trip issues for Pacific/Apia in various locales and Pacific/Honolulu in Swedish") &&\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:52:main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:442:                            && logKnownIssue("11052", "Ambiguous zone name - Samoa Time")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:53:main/common_tests/src/test/java/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java:6033:                logKnownIssue("ICU-23222", "Ensure unit aliases work correctly to avoid breaking callers");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:54:main/common_tests/src/test/java/com/ibm/icu/dev/test/util/ICUResourceBundleTest.java:706:        if (logKnownIssue("cldrbug:8903",\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:55:main/common_tests/src/test/java/com/ibm/icu/dev/test/util/ICUResourceBundleTest.java:720:        if (logKnownIssue("ICU-22681", "No localized language name for nmg")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:57:main/collate/src/test/java/com/ibm/icu/dev/test/collator/UCAConformanceTest.java:67:        if (logKnownIssue("cldrbug:6745", "UCARules.txt has problems")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:60:main/translit/src/test/java/com/ibm/icu/dev/test/translit/AnyScriptTest.java:71:                if (logKnownIssue("11171",\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:61:main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:381:        if (logKnownIssue("CLDR-17976", "ICU4C Transliterator RoundTripTest finds many problems with updated Cyrillic-Latin transform")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:62:main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:510:        String minusDevAbb = logKnownIssue("cldrbug:4375", null) ? "-[\\u0970]" : "";\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:63:main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:897:            String minusDevAbb = logKnownIssue("cldrbug:4375", null) ? "-[\\u0970]" : "";\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:66:main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:189:     * This method returns true unless -prop:logKnownIssue=no is specified\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:67:main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:196:     * @return true unless -prop:logKnownIssue=no is specified in the test command line argument.\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:68:main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:198:    protected static boolean logKnownIssue(String ticket, String comment) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:69:main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:199:        if (!getBooleanProperty("logKnownIssue", true)) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:70:main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:207:        getParams().knownIssues.logKnownIssue(path, ticket, comment);\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:71:main/framework/src/test/java/com/ibm/icu/dev/test/UnicodeKnownIssues.java:68:     * Call this from the test framework when logKnownIssue() is called.\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/logKnownIssues.txt:72:main/framework/src/test/java/com/ibm/icu/dev/test/UnicodeKnownIssues.java:78:    public void logKnownIssue(String path, String ticket, String comment) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/timezone/TimeZoneTest.java:205:                } else if (!(referenceZone.getID().equals("ART") && logKnownIssue("ICU-22436", "Wrong DST status for time zone ART"))) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/calendar/CalendarTestFmwk.java:263:                if (cal.getType().equals("hebrew") && greg.get(Calendar.YEAR)>2500 && logKnownIssue("ICU-22441", "Hebrew calendar illegal year length")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/calendar/IBMCalendarTest.java:273:        if (!logKnownIssue("ICU-22924", "wbl-Arab returns wrong first day of the week, probably caused by wrong Likely Subtag algo")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/calendar/IBMCalendarTest.java:2289:                    logKnownIssue("ICU-22230", "Problem December in Leap Year");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:895:                    logKnownIssue("ICU-23185", "Date time formatting with hz and hv needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:900:                    logKnownIssue("ICU-23185", "Date time formatting with hz and hv needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:1839:                    if (logKnownIssue("ICU-11585", "incompatible pattern between date format and date interval format")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/DateIntervalFormatTest.java:2585:                logKnownIssue("CLDR-18923", "Quoting in scn atTime/relative dateTimeFormats causes format/parse issues");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/IntlTestDateFormat.java:272:                    logKnownIssue("CLDR-18923", "Quoting in scn atTime/relative dateTimeFormats causes format/parse issues");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/PersonNameConsistencyTest.java:89:                logKnownIssue(knownIssue, "Exception thrown on " + filename + ": " + e.toString());\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/format/PersonNameConsistencyTest.java:99:                logKnownIssue(knownIssue, "Failure in " + filename + ": Found " + errors + " errors.");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java:61:            if (!locale.getBaseName().startsWith("ks_Deva") || !logKnownIssue("22099", "locale-specific parse sets not supported")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/number/ExhaustiveNumberTest.java:64:            if (!locale.getBaseName().startsWith("nqo") || !logKnownIssue("CLDR-17023", "Number symbols and/or parseLenients messed up for N\xe2\x80\x99Ko")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:25:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:37:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:38:        uki.logKnownIssue("d/e/f", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:39:        uki.logKnownIssue("g/h/i", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:54:        uki.logKnownIssue("a/b/c", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:55:        uki.logKnownIssue("d/e/f", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:56:        uki.logKnownIssue("g/h/i", "ICU-21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:70:        uki.logKnownIssue("a/b/c", "21756", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:82:        uki.logKnownIssue("a/b/c", "zzz", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:94:        uki.logKnownIssue("a/b/c", "CLDR-9787", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/core/src/test/java/com/ibm/icu/dev/test/TestUnicodeKnownIssues.java:106:        uki.logKnownIssue("a/b/c", "cldrbug:9787", "Something is working!");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:564:            if (logKnownIssue("10494", "PluralRules is not serializable")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:580:            if (logKnownIssue("10494", "PluralRules is not de-serializable")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java:707:        if (!logKnownIssue("ICU-23188", "Compact number formatting for ar-EG adds extra RLM")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:253:        // !! if (!logKnownIssue("CLDR-18905", "German narrow change needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:263:        if (!logKnownIssue("CLDR-18905", "German narrow change needs revisiting")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:536:                    logKnownIssue("CLDR-18905", "German narrow change needs revisiting")\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/MeasureUnitTest.java:1594:            //\tlogKnownIssue("ICU-22781", "Handle concentr/perbillion in ICU");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberFormatTest.java:5562:        if (logKnownIssue("12045", "XSU is missing from fr")) { return; }\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberFormatTest.java:7173:            //    logKnownIssue("CLDR-18274", "The data for portion-per-XYZ is not determined yet.");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/PluralRulesTest.java:1169:                        logKnownIssue("10783", "Fix issues with isLimited vs computeLimited on ordinals");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:147:            if (logKnownIssue("CLDR-18924", "Timezone round trip issues in ku, shn, sv for various zones") &&\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:415:                \tif (logKnownIssue("CLDR-18924", "Time round trip issues for Pacific/Apia in various locales and Pacific/Honolulu in Swedish") &&\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/TimeZoneFormatTest.java:442:                            && logKnownIssue("11052", "Ambiguous zone name - Samoa Time")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/number/NumberFormatterApiTest.java:6033:                logKnownIssue("ICU-23222", "Ensure unit aliases work correctly to avoid breaking callers");\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/util/ICUResourceBundleTest.java:706:        if (logKnownIssue("cldrbug:8903",\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/util/ICUResourceBundleTest.java:720:        if (logKnownIssue("ICU-22681", "No localized language name for nmg")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/collate/src/test/java/com/ibm/icu/dev/test/collator/UCAConformanceTest.java:67:        if (logKnownIssue("cldrbug:6745", "UCARules.txt has problems")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/translit/src/test/java/com/ibm/icu/dev/test/translit/AnyScriptTest.java:71:                if (logKnownIssue("11171",\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:381:        if (logKnownIssue("CLDR-17976", "ICU4C Transliterator RoundTripTest finds many problems with updated Cyrillic-Latin transform")) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:510:        String minusDevAbb = logKnownIssue("cldrbug:4375", null) ? "-[\\u0970]" : "";\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/translit/src/test/java/com/ibm/icu/dev/test/translit/RoundTripTest.java:897:            String minusDevAbb = logKnownIssue("cldrbug:4375", null) ? "-[\\u0970]" : "";\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:189:     * This method returns true unless -prop:logKnownIssue=no is specified\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:196:     * @return true unless -prop:logKnownIssue=no is specified in the test command line argument.\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:198:    protected static boolean logKnownIssue(String ticket, String comment) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:199:        if (!getBooleanProperty("logKnownIssue", true)) {\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/TestFmwk.java:207:        getParams().knownIssues.logKnownIssue(path, ticket, comment);\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/UnicodeKnownIssues.java:68:     * Call this from the test framework when logKnownIssue() is called.\n/usr/local/google/home/ccornelius/ICU78-new/icu/icu4j/main/framework/src/test/java/com/ibm/icu/dev/test/UnicodeKnownIssues.java:78:    public void logKnownIssue(String path, String ticket, String comment) {\n'


Issue: This text looks wrong to include in the PR

sven-oly · 2025-10-09T00:26:40Z

PTAL. The previous push had some errors.

Reclassifying ERRORS in data generation - see issue unicode-org#238

bb2cbab

gemini-code-assist bot reviewed Sep 5, 2025

View reviewed changes

testgen/generators/base.py Outdated Show resolved Hide resolved

Change exception type

bb879c8

sven-oly assigned echeran and sffc Sep 8, 2025

sffc requested changes Sep 24, 2025

View reviewed changes

sven-oly added 2 commits October 9, 2025 00:12

Fix type of exceptions

66bd66b

merging

20a940e

sven-oly force-pushed the reclassify_warnings_errors branch from 4b59076 to 20a940e Compare October 9, 2025 00:23

sffc approved these changes Oct 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Reclassifying ERRORS in data generation - see issue #238 #525

Reclassifying ERRORS in data generation - see issue #238 #525

Uh oh!

sven-oly commented Sep 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

sven-oly commented Sep 24, 2025

Uh oh!

sffc Sep 24, 2025

Uh oh!

sven-oly commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Reclassifying ERRORS in data generation - see issue #238 #525

Are you sure you want to change the base?

Reclassifying ERRORS in data generation - see issue #238 #525

Uh oh!

Conversation

sven-oly commented Sep 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

sven-oly commented Sep 24, 2025

Uh oh!

sffc Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

sven-oly commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants