Skip to content

CLDR-19058 test: document the 'mini-cldr-root' in testdata #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CLDR-19058 test: document the 'mini-cldr-root' in testdata #5139

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 11, 2025

  • this is for testing, so rip out a bunch of the DTD so it doesn't trigger searches, and add scary notices.

CLDR-19058

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Oct 11, 2025
@srl295
CLDR-19058 test: document the 'mini-cldr-root' in testdata
2474067 
- this is for testing, so rip out a bunch of the DTD so it doesn't trigger searches, and add scary notices.
@srl295 srl295 force-pushed the cldr-19058/doc-test-dtd branch from 5090a6f to 2474067 Compare October 11, 2025 19:01
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/test/java/org/unicode/cldr/util/TestCLDRFileMore.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 marked this pull request as ready for review October 11, 2025 19:56
robertbastian
robertbastian approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@robertbastian robertbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have seen those warnings, but removing content that would show up in searches probably fixes most of the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertbastian robertbastian robertbastian approved these changes

@btangmu btangmu Awaiting requested review from btangmu

@macchiati macchiati Awaiting requested review from macchiati

@AEApple AEApple Awaiting requested review from AEApple

Assignees

@srl295 srl295

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@srl295 @robertbastian