More filtering in dashboard

[srugano]

AB#244486

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (c44ef45) to head (f0be9fb).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4751      +/-   ##
===========================================
+ Coverage    86.14%   86.15%   +0.01%     
===========================================
  Files          586      586              
  Lines        36775    36775              
===========================================
+ Hits         31680    31684       +4     
+ Misses        5095     5091       -4     

Flag	Coverage Δ
e2e	60.12% <100.00%> (-0.04%)	⬇️
unittests	84.65% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/hct_mis_api/apps/dashboard/services.py:36

• Changing the filter to include both 'ACCEPTED' and 'FINISHED' statuses for total_payment_plans may affect aggregation logic. Confirm that this update aligns with the intended business rules.

total_payment_plans = Count("parent__id", filter=Q(parent__status__in=["ACCEPTED", "FINISHED"]), distinct=True)

src/hct_mis_api/apps/dashboard/services.py:143

• Switching to a distinct count for 'reconciled' may lead to different aggregation results. Ensure that this modification accurately reflects the desired reconciliation logic.

reconciled=Count("pk", distinct=True, filter=Q(payment_verifications__isnull=False))

src/hct_mis_api/apps/dashboard/services.py:96

• The addition of 'excluded=False' in the query should be verified to ensure the 'excluded' field is defined and behaves as expected in the data model.

excluded=False,