RDI Access change for retrieving data from Kobo Reinstated #4507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4507 +/- ##
===========================================
+ Coverage 86.49% 86.80% +0.31%
===========================================
Files 624 624
Lines 37703 37641 -62
===========================================
+ Hits 32612 32676 +64
+ Misses 5091 4965 -126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ntrncic
reviewed
Mar 3, 2025
| class TestResolveAssetsList: | ||
| @pytest.fixture(autouse=True) | ||
| def use_kobo_master_token(self, settings: Any) -> None: | ||
| settings.KOBO_MASTER_API_TOKEN = "test-token" |
There was a problem hiding this comment.
how does this test run, on production, there is a token?
…data-from-Kobo-NEW # Conflicts: # development_tools/.env.example # src/hct_mis_api/apps/core/kobo/api.py # src/hct_mis_api/apps/core/models.py # src/hct_mis_api/apps/core/schema.py # src/hct_mis_api/config/settings.py
…data-from-Kobo-NEW
…data-from-Kobo-NEW
pavlo-mk
approved these changes
Jul 2, 2025
pkujawa
approved these changes
Jul 2, 2025
…trieving-data-from-Kobo-NEW' into feature/RDI-Access-change-for-retrieving-data-from-Kobo-NEW
…data-from-Kobo-NEW
pavlo-mk
deleted the
feature/RDI-Access-change-for-retrieving-data-from-Kobo-NEW
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#198299
This pull request includes several changes to the
koboAPI and related files to improve the functionality and maintainability of the codebase. The most important changes include the refactoring of theKoboAPIclass, updates to the environment configurations, and removal of deprecated code.Refactoring of
KoboAPIclass:src/hct_mis_api/apps/core/kobo/api.py: Refactored theKoboAPIclass to simplify initialization and request handling, including the removal of theBusinessAreadependency and the introduction of_get_requestand_get_paginated_requestmethods. [1] [2] [3] [4] [5]Updates to environment configurations:
development_tools/.env.example: AddedKOBO_PROJECT_VIEWS_IDto the.env.examplefile.src/hct_mis_api/config/env.py: AddedKOBO_PROJECT_VIEWS_IDto the environment configuration.src/hct_mis_api/config/settings.py: AddedKOBO_PROJECT_VIEWS_IDto the settings.Removal of deprecated code:
src/hct_mis_api/apps/core/kobo/common.py: Removed thefilter_by_ownerfunction.src/hct_mis_api/apps/core/models.py: Markedkobo_usernameas deprecated with a TODO comment for future removal.Additional changes:
src/hct_mis_api/apps/core/schema.py: Updatedresolve_assetandresolve_assets_listfunctions to use the refactoredKoboAPIclass and handle the newCountryCodeNotProvidedexception. [1] [2] [3] [4]tests/unit/apps/core/kobo/cassettes/TestKoboAPI.test_get_project_submissions_only_active_submissions.yaml: Added a new test cassette for thetest_get_project_submissions_only_active_submissionsmethod.