Fix error when save dashboard

unicef-drp · Aug 14, 2023 · 57039f9 · 57039f9
1 parent a5146e8
commit 57039f9
Showing 1 changed file with 17 additions and 15 deletions.
diff --git a/django_project/geosight/data/models/dashboard/dashboard.py b/django_project/geosight/data/models/dashboard/dashboard.py
@@ -308,21 +308,23 @@ def save_relations(self, data):
 
             rules_ids = []
             rules = model.dashboardindicatorlayerrule_set.all()
-            for idx, rule in enumerate(layer_data.get('style', [])):
-                if 'indicator' in rule:
-                    continue
-                _rule, created = DSLayerRule.objects.get_or_create(
-                    object=model,
-                    name=rule['name']
-                )
-                _rule.rule = rule['rule']
-                _rule.color = rule['color']
-                _rule.outline_color = rule['outline_color']
-                _rule.outline_size = rule['outline_size']
-                _rule.active = rule['active']
-                _rule.order = idx
-                _rule.save()
-                rules_ids.append(_rule.id)
+            layer_data_style = layer_data.get('style', [])
+            if isinstance(layer_data_style, list):
+                for idx, rule in enumerate(layer_data_style):
+                    if 'indicator' in rule:
+                        continue
+                    _rule, created = DSLayerRule.objects.get_or_create(
+                        object=model,
+                        name=rule['name']
+                    )
+                    _rule.rule = rule['rule']
+                    _rule.color = rule['color']
+                    _rule.outline_color = rule['outline_color']
+                    _rule.outline_size = rule['outline_size']
+                    _rule.active = rule['active']
+                    _rule.order = idx
+                    _rule.save()
+                    rules_ids.append(_rule.id)
             rules.exclude(id__in=rules_ids).delete()
 
             # -----------------------------------------------------