Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/send ticket #261

Merged
merged 13 commits into from
Nov 26, 2024
Merged

Feat/send ticket #261

merged 13 commits into from
Nov 26, 2024

Conversation

Suboyyy
Copy link
Contributor

@Suboyyy Suboyyy commented Nov 26, 2024

Send général mail

Changes

  • Route to send general mail
  • Redo mail system

DO NOT DELETE THE BRANCH

gmail: loadEnv('GMAIL') === 'true',
username: loadEnv('GMAIL_USERNAME') || null,
password: loadEnv('GMAIL_PASSWORD') || null,
partners: ['utt.fr', 'utc.fr', 'utbm.fr'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal de plus avoir les partners (@utt @UTC @utbm ?)

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 54.13534% with 61 lines in your changes missing coverage. Please review.

Project coverage is 92.58%. Comparing base (9ca2dcc) to head (a6ae230).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/controllers/admin/emails/sendCustom.ts 22.85% 27 Missing ⚠️
src/services/email/templates/orderConfirmation.ts 35.71% 9 Missing ⚠️
src/controllers/admin/emails/sendTemplate.ts 46.15% 7 Missing ⚠️
src/services/email/targets.ts 53.84% 6 Missing ⚠️
src/controllers/admin/emails/send.ts 25.00% 3 Missing ⚠️
src/services/email/templates/tickets.ts 62.50% 3 Missing ⚠️
src/operations/user.ts 0.00% 1 Missing ⚠️
src/services/email/templates/joinDiscord.ts 66.66% 1 Missing ⚠️
src/services/email/templates/lastYearAnnounce.ts 75.00% 1 Missing ⚠️
src/services/email/templates/minor.ts 66.66% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #261      +/-   ##
==========================================
- Coverage   95.11%   92.58%   -2.54%     
==========================================
  Files         121      133      +12     
  Lines        2826     2886      +60     
  Branches      425      424       -1     
==========================================
- Hits         2688     2672      -16     
- Misses        106      182      +76     
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Suboyyy Suboyyy merged commit 3c8d058 into dev Nov 26, 2024
5 of 6 checks passed
Suboyyy added a commit that referenced this pull request Nov 27, 2024
* Feat/send ticket (#261)

* feat: new email system

* feat: add General Mail route

* feat: back to street legal

* feat: add sendTemplate

* fix: it's better with .fr

* fix: update email template topics

* fix: add return and fix preview undefined

* fix: change minor mail target

* fix: lint

* fix: lint2

* test: disable mail tests

* test: disable other mail test

---------

Co-authored-by: Noé Landré <[email protected]>
Co-authored-by: Arthur Dodin <[email protected]>
Co-authored-by: Antoine D <[email protected]>

* fix: comment notPaid template tournament cancel

---------

Co-authored-by: Noé Landré <[email protected]>
Co-authored-by: Arthur Dodin <[email protected]>
Co-authored-by: Antoine D <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants