-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pokemon player #150
Feat/pokemon player #150
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #150 +/- ##
=======================================
Coverage 96.50% 96.51%
=======================================
Files 108 108
Lines 2292 2294 +2
Branches 330 331 +1
=======================================
+ Hits 2212 2214 +2
Misses 44 44
Partials 36 36
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice trop bien !
Il manque encore les tests :)
Faudrait aussi retourner le pokémonId au front (je pense aux routes GET /user/current
et GET /admin/users
)
Et dernier truc auquel je pense : il faudrait check au moment de la création de l'équipe si c'est une équipe du tournoi pokémon, et si oui, faire en sorte que le champ soit obligatoire (renvoyer une erreur s'il n'est pas présent, t'embête pas à utiliser les middlewares)
88beff2
to
637ff52
Compare
* feat: add pokemonplayerid in teams table -> db * fix: change Int type to String in Db * feat: add pokemonPlayerId to POST /teams endpoint parameters * feat: add pokemonplayerid in teams table -> db * fix: fix linter advices * fix: bugs * changed field pokemonPlayerId in table Tournament to String * return error on team creation if the pokemonPlayerId is not specified but the tournament is the pokemon tournament * feat: add test and fix issues on Prisma * docs: add some docs * fix: lint * fix: typo --------- Co-authored-by: Teddy Roncin <[email protected]> Co-authored-by: Noé Landré <[email protected]> Co-authored-by: Noé Landré <[email protected]>
PR name
Feature: let pokemon players add their play! playerId into database
Changes
Add new column in teams db table
Rework /teams POST endpoint to allow new parameter (optional parameter)
-> A string with regex [0-9]+
Breaking changes
What's left to do (DELTE THIS PART FOR NON-DRAFT PRs)
Merge the front pull request after this one