hanningfix #128
Open
hanningfix #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
behinger
commented
Dec 13, 2024
behinger
commented
- FormulaOnsets
- initial sequence tryout
- fix bug in predef_eeg
- fix \beta missing
- forgot the end
- half way through to success for sequence designs or something
- everythinig except sequencelength seems to be working now
- added string sequence tests
- small doc update
- added jitter to the '_' trial divisor
- generalized LinearModelComponent to arbitrary functions instead of vectors
- bugfix with endless loop due to multiple dispatch
- function component for multi-subject
- forgot to define offset in LinearModelFunction
- Improve documentation especially quickstart, home and power analysis
- adapted the order of reference overviews and adapted titles
- Updated quickstart page
- minor changes
- fixed docstrings for predef_eeg and predef_2x2
- added draft of design types reference page
- Update quickstart.jl
- Add UnfoldSim logo to the documentation
- Finished experimental design reference page
- Replace logo file
- Update logo file
- Delete docs/src/assets/logo.svg
- Add logo as png file
- Added intro paragraph for Simulate ERP tutorial
- Improved docstrings for single- and multi-subject design
- Fixed simulate docstring
- Added cross references in docstrings
- Added intro sentences, matched titles and sidebar, reordered pages and added collapsible setup blocks
- Update noise.jl
- Update src/noise.jl
- Update src/noise.jl
- Update src/noise.jl
- add empty line for formatting reasons
- Update docs/literate/reference/noisetypes.jl
- Update docs/literate/reference/overview.jl
- Update docs/literate/reference/overview.jl
- Update docs/literate/reference/noisetypes.jl
- added docstring
- renamed to have the formula at the end
- merge fix, double definition of function
- component function test + docstring
- better docs
- added unittests
- fixed small wording
- fix tutorial with v0.3 renaming of simulate to simulate_component
- fix newComponent tutorial
- fix sequence design rng
- fix sequence test
- fix rng docs
- fix Change Simulation struct field "components" from Type Dict to NamedTuple Type. #124, explicitly cast the dict
- not sure where this error came in...
- hanning upgrade
- checking stuff
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/literate/HowTo/newComponent.jl
Outdated
| @@ -62,7 +67,8 @@ function basis_shiftduration(evts, maxlength) | |||
| end | |||
|
|
|||
| # ## Simulate data with the new component type | |||
| erp = UnfoldSim.simulate( | |||
| erp = UnfoldSim.simulate_component( | |||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
docs/literate/HowTo/sequence.jl
Outdated
| xlims!(0, 500) | ||
| current_figure() | ||
|
|
||
| # As visible, the `R` response always follows the `S` response. Due to the "`_`" we have large breaks between the individual sequences. |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # As visible, the `R` response always follows the `S` response. Due to the "`_`" we have large breaks between the individual sequences. | |
| # As visible, the `R` response always follows the `S` response. Due to the "`_`" we have large breaks between the individual sequences. |
| @@ -40,7 +40,9 @@ design_single_shuffled = SingleSubjectDesign(; | |||
| :stimulus_type => ["natural", "artificial"], | |||
| :contrast_level => range(0, 1, length = 3), | |||
| ), | |||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| event_order_function = shuffle, | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| axislegend(ax) | ||
| f | ||
|
|
||
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` | |
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` |
src/design.jl
Outdated
| SequenceDesign(design, sequence) = | ||
| SequenceDesign(design = design, sequence = sequence) | ||
|
|
||
| generate_events(rng,design::SequenceDesign{MultiSubjectDesign}) = error("not yet implemented") |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| generate_events(rng,design::SequenceDesign{MultiSubjectDesign}) = error("not yet implemented") | |
| generate_events(rng, design::SequenceDesign{MultiSubjectDesign}) = | |
| error("not yet implemented") |
src/design.jl
Outdated
| function UnfoldSim.generate_events(rng::AbstractRNG, design::RepeatDesign) | ||
| df = map(x -> generate_events(rng, design.design), 1:design.repeat) |> x -> vcat(x...) | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/design.jl
Outdated
| # No way to find out what size it is without actually generating first... | ||
| Base.size( | ||
| design::Union{<:SequenceDesign,<:SubselectDesign,<:RepeatDesign{<:SequenceDesign}}, | ||
| ) = size(generate_events(design), 1) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ) = size(generate_events(design), 1) | |
| ) = size(generate_events(design), 1) |
src/onset.jl
Outdated
Comment on lines
210
to
211
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test argmin(n170(; sfreq)) == 0.17 * sfreq | ||
| @test argmax(p300(; sfreq)) == 0.3 * sfreq | ||
| @test argmin(n400(; sfreq)) == 0.4 * sfreq | ||
| end |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.