feat: warning icon for form errors on tabs #1403
Open
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature just simply introduces a small styling change for fieldset and inline tabs, so when a form error occurs, every fieldset and inline tab containing a field with an error now indicates it has an error.
Currently, when a form error occurs and fieldset tabs are in use, it is not clear in which tab the error occured under:

Example here a field under the "Other Information" tab had an error:

An example when multiple tabs have fields with form errors:

Example when multiple inlines with tabs had errors:
