Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reference links for cel-go in footer (#27) #31

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

marcelloale
Copy link
Contributor

Description

Add reference links for cel-go and Language definition to the footer of the site.

Linked Issues

Closes #27

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@lucasjct
Copy link
Contributor

lucasjct commented Oct 3, 2023

Thank you for your time, @marcelloale.

We have some considerations about your PR.

We need the links and text, "Language definition" and "cel-go v0.16.0," to be separated. You can use a pipe for this. Please see the example below:

image

Let me know if you have any question.
Thanks!

@marcelloale
Copy link
Contributor Author

Thank you for your feedback, @lucasjct . I have made the necessary adjustments in css to the PR.

web/index.html Outdated Show resolved Hide resolved
@marcelloale
Copy link
Contributor Author

Done ✅

@lucasjct lucasjct added the hacktoberfest-accepted Accept PR from hacktoberfest label Oct 5, 2023
@lucasjct
Copy link
Contributor

lucasjct commented Oct 5, 2023

@marcelloale, thank you for your collaboration!

Your PR has been accepted and will be merged.

@lucasjct lucasjct merged commit bb85945 into undistro:main Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept PR from hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reference links for cel-go and Language definition overview.
3 participants