Remove broken debug bindings #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Apr 17, 2023
| @@ -133,7 +132,7 @@ export class Grid extends Primitive { | |||
| // Register lines | |||
| const lines = (() => { | |||
| const result = []; | |||
| for (axis of this.axes) { | |||
| for (const axis of this.axes) { | |||
There was a problem hiding this comment.
this was rebinding the function binding...
sritchie
commented
Apr 17, 2023
| @@ -183,12 +182,14 @@ export class Grid extends Primitive { | |||
| touched["origin"] || | |||
| init | |||
| ) { | |||
| return this.updateRanges(); | |||
There was a problem hiding this comment.
these artifacts are all over the codebase from the coffeescript conversion.
sritchie
commented
Apr 17, 2023
| } | ||
| window.cake1 = this.axes[0].buffer; |
sritchie
commented
Apr 17, 2023
| } | ||
| const x = Array.from(dimensions).includes(1) ? 0 : origin.x; |
There was a problem hiding this comment.
while debugging a different problem that turned out to be user error, I introduced this mild cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I left a couple of debug bindings in grid.js, which caused an exception when
lineXorlineYwere set to false.I also found it very confusing that
originwas able to be used before being defined. This feels like a messy bug where theoriginproperty is used first... and theconst originlater in the file was re-binding this variable? That shouldn't be possible but removing theoriginbinding didn't cause any errors, which was troubling.axisthe variable andaxisthe function were clashing as well, so I did some renaming there to make things unambiguous.