fix: convert page_timeout ms to seconds for aiohttp (#1894)#1895
Open
hafezparast wants to merge 1 commit intounclecode:developfrom
Open
fix: convert page_timeout ms to seconds for aiohttp (#1894)#1895hafezparast wants to merge 1 commit intounclecode:developfrom
hafezparast wants to merge 1 commit intounclecode:developfrom
Conversation
unclecode#1894) page_timeout is in milliseconds (Playwright convention, default 60000ms), but AsyncHTTPCrawlerStrategy passed it directly to aiohttp.ClientTimeout which expects seconds. This made the default timeout 60,000 seconds (16.7 hours) instead of 60 seconds, effectively disabling timeouts for HTTP mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page_timeoutis in milliseconds (Playwright convention, default60000), butAsyncHTTPCrawlerStrategy._handle_httppassed it directly toaiohttp.ClientTimeout(total=...)which expects seconds. This made the default timeout 60,000 seconds (16.7 hours) instead of 60 seconds.Fixes #1894
The Bug
The Fix
Changes
crawl4ai/async_crawler_strategy.py: 1 line — dividepage_timeoutby 1000 before passing toClientTimeouttests/test_http_timeout_unit_1894.py: 8 tests verifying the conversionTest plan
🤖 Generated with Claude Code