implement shop page search params #81
Open
+240
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unchihugo
changed the title
|
@unchihugo I think we should go ahead with whatever version you think is best, I'm completely fine with either I think both implementations are good 😊 |
dummy payment
…into Admin-Dashboard
unchihugo
requested changes
Mar 21, 2025
There was a problem hiding this comment.
Hi, there are a few issues in the branch, could you try to test and fix it?
- Search params aren't working properly. I'm getting 400 Bad Request when searching with a category param, most likely the categoryID's aren't being passed through properly. Also, selecting a category or searching does not update the url.
- For some reason the page constantly refreshes (dozens of times a second), even if it's unneeded. Try making sure the useEffect functions are activating only when necessary.
- Selecting the "By Category" category displays nothing.
|
ill solve the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.