-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish reviews section #79
Conversation
@michaeltukdev ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's only two things
- You can't update a review, there is no way, it simply updates the review to 'Updated review' currently.
- You have validation for the reviews but it's not passed to the user to see the error. I found this out when I tried to submit a review less than 10 characters. This also isn't a requirement on the backend but still pretty nice to have. The only validation on backend is required and max 255 characters.
Apart from that, good work.
the latest commits added updating, but thanks for catching the validation errors! I totally missed implementing that |
Just tested it and yeah the updating works, my bad. Let me know when the errors are implemented. |
…fix wrapping
if not logged in
if user logged in and has no review
if user logged in and has review