Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish reviews section #79

Merged
merged 7 commits into from
Mar 20, 2025
Merged

Finish reviews section #79

merged 7 commits into from
Mar 20, 2025

Conversation

unchihugo
Copy link
Owner

  • Add user reviewing functionality
    • Add supporting backend function and route
  • Fix backend password validation
  • Switch emoji stars to Lucide icons

if not logged in

image

if user logged in and has no review

image

if user logged in and has review

image

@unchihugo unchihugo marked this pull request as ready for review March 19, 2025 11:35
@unchihugo
Copy link
Owner Author

@michaeltukdev ready for review

Copy link
Collaborator

@michaeltukdev michaeltukdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only two things

  • You can't update a review, there is no way, it simply updates the review to 'Updated review' currently.
  • You have validation for the reviews but it's not passed to the user to see the error. I found this out when I tried to submit a review less than 10 characters. This also isn't a requirement on the backend but still pretty nice to have. The only validation on backend is required and max 255 characters.

Apart from that, good work.

@unchihugo
Copy link
Owner Author

There's only two things

  • You can't update a review, there is no way, it simply updates the review to 'Updated review' currently.
  • You have validation for the reviews but it's not passed to the user to see the error. I found this out when I tried to submit a review less than 10 characters. This also isn't a requirement on the backend but still pretty nice to have. The only validation on backend is required and max 255 characters.

Apart from that, good work.

the latest commits added updating, but thanks for catching the validation errors! I totally missed implementing that

@michaeltukdev
Copy link
Collaborator

There's only two things

  • You can't update a review, there is no way, it simply updates the review to 'Updated review' currently.
  • You have validation for the reviews but it's not passed to the user to see the error. I found this out when I tried to submit a review less than 10 characters. This also isn't a requirement on the backend but still pretty nice to have. The only validation on backend is required and max 255 characters.

Apart from that, good work.

the latest commits added updating, but thanks for catching the validation errors! I totally missed implementing that

Just tested it and yeah the updating works, my bad. Let me know when the errors are implemented.

…fix wrapping
@unchihugo unchihugo merged commit fb8e465 into main Mar 20, 2025
3 checks passed
@unchihugo unchihugo deleted the finish-reviews-section branch March 20, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants