Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vckit docker integration #90

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

ashleythedeveloper
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds Docker integration for vckit. It includes the following changes:

  1. Updates the docker-compose.yml file to include vckit-api and PostgreSQL database services.
  2. Adds a local.env file with necessary environment variables for the vckit-api service.
  3. Updates the README.md with instructions for using Docker Compose.

These changes will allow users to easily set up and run vckit in a containerized environment, improving deployment consistency and ease of use.

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-08-06 at 7 18 53β€―PM Screenshot 2024-08-06 at 7 19 17β€―PM

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

Copy link

github-actions bot commented Aug 6, 2024

Coverage report

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from 97daf02

Copy link
Collaborator

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashleythedeveloper ashleythedeveloper merged commit 308068b into next Aug 6, 2024
2 checks passed
@ashleythedeveloper ashleythedeveloper deleted the feat/vckit-docker-integration branch August 6, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants