-
Notifications
You must be signed in to change notification settings - Fork 22
Added new section DPP -> Data Model Changes -> 7. traceabilityInformation and refined 2. Credential Subject Structure #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¦tion and refined 2. Credential Subject Structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @karinaliauw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the 0.6.0 migration guides for the Digital Product Passport (DPP). It clarifies significant data model changes by adding a new section for traceabilityInformation structure updates and refining the description of the Credential Subject Structure. These documentation enhancements aim to provide clearer guidance on how certain fields have been reorganized within the ProductPassport and how traceabilityInformation now supports multiple entries, improving the overall clarity and completeness of the migration guide.
Highlights
- Traceability Information Structure: A new section has been added to the Digital Product Passport (DPP) Data Model Changes, specifically detailing updates to the
traceabilityInformationstructure. - Credential Subject Structure Refinement: The documentation for the
Credential Subject Structurehas been refined to explicitly state that fields such asgranularityLevel,dueDiligenceDeclaration,materialsProvenance,circularityScorecard,emissionsScorecard, andtraceabilityInformationhave been moved from theProductlevel to theProductPassportlevel. - Traceability Information Data Type Change: The
traceabilityInformationdata type has been updated from a single object to a list of objects to support multiple entries, with illustrative JSON examples provided.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. β©
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the v0.6.0 migration guide, adding a new section for traceabilityInformation and refining the credentialSubject structure changes. The changes are clear and improve the documentation. I've left a few comments to correct some typos and improve formatting for better readability and consistency.
|
@karinaliauw, please see the comments above. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi @ashleythedeveloper following up on this PR. Let me know you have any questions. Thank you. |
|
Hi @ashleythedeveloper following up on Karina's updates. Thank you! |
ashleythedeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?