Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement vc-api issuer interfaces #98

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

toannvit
Copy link
Contributor

Issue

Description

Changes

  • Create plugin router (vc-api-issuer)
  • Change the agent.yml file to expose issuer apis

Test results

image

@toannvit toannvit added this to the MVP0 milestone Jun 19, 2023
@toannvit toannvit self-assigned this Jun 19, 2023
@toannvit toannvit force-pushed the feat/vc-api-issuer-router branch 2 times, most recently from d7f6527 to 4b121c8 Compare June 19, 2023 11:13
@arpentnoir
Copy link
Contributor

@toannvit

  • no need to add scope to pr name or commit messages - we are not using them, we may eventually, but it means even more granular commits than already is the case with just CC type. if we do end up adding scopes to commit message structure, then I think RFCs are a good option, but we'd probably make a mapping from short scope name to RFC. for now just standard conventional commits without scope is fine.

  • it doesn't look like you are mapping request and response structures, so requests are falling through to veramo defaults.
    i.e. vc-api has an "options" object, but veramo function expects root level proofFormat, keyRef, etc...

  • I think these routers should all go in a single package - vc-api - rather than their own packages.

@toannvit toannvit changed the title feat(rfc-0031-vc-api-issuer): implement vc-api issuer interfaces feat: implement vc-api issuer interfaces Jun 20, 2023
@toannvit toannvit marked this pull request as draft June 21, 2023 08:46
@toannvit toannvit force-pushed the feat/vc-api-issuer-router branch 2 times, most recently from 087c8d3 to 080abfa Compare June 21, 2023 09:00
toanNgo added 2 commits June 21, 2023 16:05
@toannvit toannvit marked this pull request as ready for review June 21, 2023 09:07
@arpentnoir arpentnoir merged commit eddb0c9 into uncefact:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants