Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement OAuth middleware for express API #95

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

namhoang1604
Copy link
Contributor

Description:

This pull request introduces the OAuth middleware package, that can be used to replace the basic authentication using apiKey. The OAuth middleware enables secure authentication and authorization for API endpoints. This middleware will streamline the authentication process, and handle access token verification.

Related ticket(s):

#94

Checklist

  • The code follows the project's coding style guidelines.
  • All unit tests pass successfully.
  • Any new dependencies are properly documented.
  • The documentation is updated to reflect the changes (if applicable).
  • The code has been reviewed by at least one other team member.

Signed-off-by: Nam Hoang <[email protected]>
Copy link
Contributor

@arpentnoir arpentnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I would just remove the change to default config. maybe add new default example config file that shows how to configure the oauth plugin

packages/cli/default/default.yml Outdated Show resolved Hide resolved
@arpentnoir arpentnoir merged commit 7428088 into uncefact:main Jun 21, 2023
1 check failed
@namhoang1604 namhoang1604 deleted the feat/oauth-middleware branch August 7, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants