Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement credential oa plugin #83

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

toannvit
Copy link
Contributor

@toannvit toannvit commented Jun 5, 2023

Description

  • This plugin is used for issuing and verifying verifiable credential that conform to Open Attestation framework
  • uncefact/project-vckit ’s goals is to support issuing and verifying verifiable credential in both W3C and Open Atttestation framework , so this plugin is packed inside uncefact/project-vckit core but it can be plugged into any platform/library that using Veramo architecture.

Issue

Changes

  • create new package credential-oa
  • create new interface inherited from Veramon
  • implement ICredentialPlugin
  • write unit tests
  • write docs

Note

  • Right now the plugin only support did:ethr type for signing and identity verification.

@toannvit toannvit self-assigned this Jun 5, 2023
@toannvit toannvit marked this pull request as draft June 5, 2023 02:35
@toannvit toannvit marked this pull request as ready for review June 7, 2023 18:34
packages/cli/src/credential.ts Outdated Show resolved Hide resolved
packages/cli/src/credential.ts Outdated Show resolved Hide resolved
packages/credential-oa/__tests__/functions.test.ts Outdated Show resolved Hide resolved
packages/credential-oa/src/action-handler.ts Outdated Show resolved Hide resolved
packages/credential-w3c/src/action-handler.ts Outdated Show resolved Hide resolved
@toannvit toannvit marked this pull request as draft June 9, 2023 04:35
@toannvit toannvit force-pushed the feat/credential-oa branch 2 times, most recently from 61e4f91 to dbd72a2 Compare June 9, 2023 07:03
@arpentnoir
Copy link
Contributor

@toannvit is this still supposed to be in draft?

@toannvit
Copy link
Contributor Author

@toannvit is this still supposed to be in draft?

No @arpentnoir. it's ready

@toannvit toannvit marked this pull request as ready for review June 13, 2023 13:24
toanNgo added 3 commits June 13, 2023 20:27
@arpentnoir arpentnoir merged commit 012aa18 into uncefact:main Jun 14, 2023
1 check failed
@namhoang1604 namhoang1604 deleted the feat/credential-oa branch June 26, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants