Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup the package workflow #209

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

kshychko
Copy link
Contributor

@kshychko kshychko commented Aug 6, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR cleans up the package workflow - removes node installation step and CI flag as we aren't doing the build outside the docker image.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Aug 6, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=25 not covered statements, but got 0

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from b48f5a0

@kshychko kshychko changed the title chore: cleanup the workflown chore: cleanup the package workflow Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants