Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add eddsa-rdfc-2022-cryptosuite Plugin #200

Merged
merged 29 commits into from
Sep 12, 2024

Conversation

huynguyen-hl
Copy link
Contributor

@huynguyen-hl huynguyen-hl commented Jul 21, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Issue a V1 VCDM with DataIntegrityProof:

image

Verify the DataIntegrityProof V1 VCDM:

image

Issue a V2 VCDM with DataIntegrityProof:

image

Verify the DataIntegrityProof V2 VCDM:

image

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/495

Declare the plugin in your Veramo agent:

# W3C credentialPlugin
credentialIssuerLD:
  $require: '@veramo/credential-ld#CredentialIssuerLD'
  $args:
    - suites:
        - $require: '@vckit/credential-data-integrity#VCkitEddsaRdfc2022'
        #  others should be included here
      contextMaps:
        - $require: '@vckit/credential-data-integrity?t=object#contexts'
        - $require: '@veramo/credential-ld?t=object#LdDefaultContexts'
        - $require: '@transmute/credentials-context?t=object#contexts'
        - $require: '@transmute/did-context?t=object#contexts'
        #  others should be included here

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@huynguyen-hl huynguyen-hl changed the title Feat: Add credential-data-integrity plugin package Feat: Add eddsa-rdfc-2022-cryptosuite Plugin Jul 21, 2024
@ashleythedeveloper
Copy link
Contributor

Test

packages/cli/default/agent.template.yml Outdated Show resolved Hide resolved
packages/cli/default/agent.template.yml Outdated Show resolved Hide resolved
packages/cli/default/default-dev.yml Outdated Show resolved Hide resolved
packages/cli/default/default-dev.yml Outdated Show resolved Hide resolved
packages/credential-data-integrity/package.json Outdated Show resolved Hide resolved
Copy link

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 46.391752577319586%

St.❔
Category Percentage Covered / Total
πŸ”΄ Statements 46.39% 90/194
πŸ”΄ Branches 0% 0/1
πŸ”΄ Functions 0% 0/7
πŸ”΄ Lines 46.39% 90/194

Test suite run success

7 tests passing in 1 suite.

Report generated by πŸ§ͺjest coverage report action from 97bc215

Copy link
Contributor

@namhoang1604 namhoang1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namhoang1604 namhoang1604 merged commit d651176 into next Sep 12, 2024
@namhoang1604 namhoang1604 deleted the feat/crypto-suite-plugin branch September 12, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants