Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using revocation list on explorer and handle no hash #192

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

namhoang1604
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR fixes the bug for bitstring status on explorer to switch to use revocation list status

Related Tickets & Documents

Fixes https://github.com/gs-gs/fa-ag-trace/issues/492

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Jun 7, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=10 not covered statements, but got 0

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from f375f73

ducpm511
ducpm511 previously approved these changes Jun 7, 2024
@namhoang1604 namhoang1604 merged commit 95ba80e into next Jun 7, 2024
2 checks passed
@namhoang1604 namhoang1604 deleted the fix/credential-status-issue branch June 7, 2024 08:39
namhoang1604 added a commit that referenced this pull request Jun 7, 2024
…tation

* 'next' of github.com:uncefact/project-vckit:
  fix: using revocation list on explorer and handle no hash (#192)
ducpm511 added a commit that referenced this pull request Jun 7, 2024
* next:
  fix: using revocation list on explorer and handle no hash (#192)
namhoang1604 added a commit that referenced this pull request Sep 19, 2024
…erge-next-to-main

* 'next' of github.com:uncefact/project-vckit: (90 commits)
  feat: enveloping proof (#207)
  feat: Add `eddsa-rdfc-2022-cryptosuite` Plugin (#200)
  chore: update bitstring status package (#211)
  docs: update identifier creation (#208)
  feat(cd): ghcr.io setup and docker image build workflow (#206)
  changed Dockerfile to use default agent.template.yml (#201) (#205)
  parameterised API Key for Docker builds (#203) (#204)
  feat: setup package workflow
  feat: create git workflow for release tagging and generate the release note (#199)
  fix: Provide meaningful error message when signature verification fails (#197)
  docs: add documentation site (#198)
  feat: implement renderer 2024 provider (#177)
  chore: update arguments and envs for the Dockerfile (#194)
  fix: using revocation list on explorer and handle no hash (#192)
  docs: add yarn to prerequisites
  chore: change node version to 20.12.2 (#187)
  chore: update default agent for Status plugin (#186)
  chore: fix the dockerfile to set entrypoint
  chore: update vckit Dockerfile (#184)
  chore: update DockerFile and agent template (#183)
  ...

Signed-off-by: Nam Hoang <[email protected]>

# Conflicts:
#	.github/workflows/build-test-publish.yml
#	.github/workflows/deploy-to-s3.yml
#	jest.config.mjs
#	package.json
#	packages/core-types/package.json
#	packages/credential-oa/__tests__/action-handler.test.ts
#	packages/credential-oa/src/action-handler.ts
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants