Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fix for dockerize #174

Merged
merged 7 commits into from
May 28, 2024
Merged

fix: bug fix for dockerize #174

merged 7 commits into from
May 28, 2024

Conversation

huynguyen-hl
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@huynguyen-hl huynguyen-hl reopened this Apr 19, 2024
@namhoang1604 namhoang1604 merged commit 7422328 into next May 28, 2024
1 check passed
@namhoang1604 namhoang1604 deleted the bug/fix-dockerize branch May 28, 2024 04:25
Copy link

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=10 not covered statements, but got 0

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from 97e0350

ducpm511 added a commit that referenced this pull request Jun 4, 2024
* next:
  chore: fix the dockerfile to set entrypoint
  chore: update vckit Dockerfile (#184)
  chore: update DockerFile and agent template (#183)
  fix: bug fix for dockerize (#174)
  chore: add cicd for running unit test when creating PR (#180)
  chore: update agent config file (#181)

# Conflicts:
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants