Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vc api for the holder and the verifier #107

Merged
merged 12 commits into from
Jul 6, 2023
Merged

feat: vc api for the holder and the verifier #107

merged 12 commits into from
Jul 6, 2023

Conversation

namhoang1604
Copy link
Contributor

@namhoang1604 namhoang1604 commented Jun 22, 2023 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

  • Implement the vc-api for the holder and verifier.
  • Implement the open api validator for the vc api router
# API base path
- - $require: '@vckit/vc-api?t=function#HolderRouter'
- - $require: '@vckit/vc-api?t=function#IssuerRouter'
    $args:
      - createCredential: createVerifiableCredential
        updateCredentialStatus: updateVerifiableCredentialStatus
- - $require: '@vckit/vc-api?t=function#VerifierRouter'
    $args:
      - verifyCredential: verifyCredential
        verifyPresentation: verifyPresentation

# VC API docs path
- - /vc-api.json
  - $require: '@vckit/vc-api?t=function#VCApiSchemaRouter'
    $args:
      - basePath: :3332

- - /vc-api-docs
  - $require: '@vckit/vc-api?t=function#VCApiDocsRouter'

Related Tickets & Documents

#100
#92
#115

Mobile & Desktop Screenshots/Recordings

image image image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 vc-kit doc site
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@namhoang1604 namhoang1604 changed the title Feat/vc api holder feat: vc api for the holder Jun 22, 2023
@arpentnoir
Copy link
Contributor

@namhoang1604 is this ready for review or still draft?

@namhoang1604
Copy link
Contributor Author

@namhoang1604 is this ready for review or still draft?

It's still in draft, I need to add the unit test and update the README

@namhoang1604 namhoang1604 self-assigned this Jun 26, 2023
@namhoang1604
feat: implement vc-api for holder
0b9515d 
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 8615407)
@namhoang1604
docs: add api docs for vc api
0f6a52a 
Signed-off-by: Nam Hoang <[email protected]>
@namhoang1604
feat: implement proving a presentation and handle for the non-impleme…
3a33462 
…nted methods

Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 91475b7)
@namhoang1604
test: add the unit test for vc-api holder
9c67dac 
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit b410589)
@namhoang1604
docs: update readme for vc api
d703c8b 
Signed-off-by: Nam Hoang <[email protected]>
(cherry picked from commit 5e6de6e)
@namhoang1604
chore: add vc api to cli package
2b657f1 
Signed-off-by: Nam Hoang <[email protected]>
@namhoang1604 namhoang1604 marked this pull request as ready for review June 26, 2023 02:37
@namhoang1604 namhoang1604 changed the title feat: vc api for the holder feat: vc api for the holder and the verifier Jul 3, 2023
@namhoang1604 namhoang1604 removed the request for review from toannvit July 3, 2023 09:06
@namhoang1604 namhoang1604 mentioned this pull request Jul 3, 2023
Closed
18 tasks
@namhoang1604 namhoang1604 merged commit 022fb56 into uncefact:next Jul 6, 2023
@namhoang1604 namhoang1604 deleted the feat/vc-api-holder branch August 7, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpentnoir arpentnoir Awaiting requested review from arpentnoir

@hoa-ngo-gs hoa-ngo-gs Awaiting requested review from hoa-ngo-gs

Assignees

@namhoang1604 namhoang1604

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namhoang1604 @arpentnoir