Skip to content

Commit

Permalink
fix: minor issues (#153)
Browse files Browse the repository at this point in the history
<!--
  For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.
  
  For a timely review/response, please avoid force-pushing additional
  commits if your PR already received reviews or comments.
  
Before submitting a Pull Request, please ensure you've done the
following:
- 📖 Read the [Contributing
Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md).
- 📖 Read the [Code of
Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md).
  - 👷‍♀️ Create small PRs. In most cases, this will be possible.
  - ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages following [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/).
- 📗 Update any related documentation and include any relevant
screenshots.
-->

## What type of PR is this? (check all applicable)

- [ ] 🍕 Feature
- [x] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Description

<!-- 
Please do not leave this blank 
This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. 
-->
- Fix migration script to ignore when the table is existing
- Rename active button to unrevoke
- Comment the did ethr in default config

## Related Tickets & Documents
<!-- 
Please use this format link issue numbers: Fixes #123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Mobile & Desktop Screenshots/Recordings

<!-- Visual changes require screenshots -->


## Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

## Added to documentation?

- [ ] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [x] 🙅 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?


<!-- note: PRs with deleted sections will be marked invalid -->

---------

Signed-off-by: Nam Hoang <[email protected]>
  • Loading branch information
namhoang1604 committed Sep 7, 2023
1 parent 9febd39 commit cf8c801
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 18 deletions.
32 changes: 16 additions & 16 deletions packages/cli/default/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -320,22 +320,22 @@ didManager:
- $ref: /dbConnection
defaultProvider: did:ethr:goerli
providers:
did:ethr:
$require: '@veramo/did-provider-ethr#EthrDIDProvider'
$args:
- defaultKms: local
network: mainnet
rpcUrl: https://mainnet.infura.io/v3/3586660d179141e3801c3895de1c2eba
gas: 1000001
ttl: 31104001
did:ethr:goerli:
$require: '@veramo/did-provider-ethr#EthrDIDProvider'
$args:
- defaultKms: local
network: goerli
rpcUrl: https://goerli.infura.io/v3/3586660d179141e3801c3895de1c2eba
gas: 1000001
ttl: 31104001
# did:ethr:
# $require: '@veramo/did-provider-ethr#EthrDIDProvider'
# $args:
# - defaultKms: local
# network: mainnet
# rpcUrl: https://mainnet.infura.io/v3/3586660d179141e3801c3895de1c2eba
# gas: 1000001
# ttl: 31104001
# did:ethr:goerli:
# $require: '@veramo/did-provider-ethr#EthrDIDProvider'
# $args:
# - defaultKms: local
# network: goerli
# rpcUrl: https://goerli.infura.io/v3/3586660d179141e3801c3895de1c2eba
# gas: 1000001
# ttl: 31104001
did:web:
$require: '@veramo/did-provider-web#WebDIDProvider'
$args:
Expand Down
2 changes: 1 addition & 1 deletion packages/demo-explorer/src/components/CredentialInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const CredentialInfo: React.FC<CredentialInfoProps> = ({
}}
disabled={loading}
>
Active
Unrevoke
</Button>
) : (
<Button
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export class CreateDatabase1688974564002 implements MigrationInterface {
),
},
],
})
}),
true
);
}

Expand Down

0 comments on commit cf8c801

Please sign in to comment.