Skip to content

Commit

Permalink
feat: credential router (#139)
Browse files Browse the repository at this point in the history
<!--
  For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.
  
  For a timely review/response, please avoid force-pushing additional
  commits if your PR already received reviews or comments.
  
Before submitting a Pull Request, please ensure you've done the
following:
- 📖 Read the [Contributing
Guide](https://github.com/uncefact/project-vckit/blob/main/CONTRIBUTING.md).
- 📖 Read the [Code of
Conduct](https://github.com/uncefact/project-vckit/blob/main/CODE_OF_CONDUCT.md).
  - 👷‍♀️ Create small PRs. In most cases, this will be possible.
  - ✅ Provide tests for your changes.
- 📝 Use descriptive commit messages following [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/).
- 📗 Update any related documentation and include any relevant
screenshots.
-->

## What type of PR is this? (check all applicable)

- [x] 🍕 Feature
- [ ] 🐛 Bug Fix
- [ ] 📝 Documentation Update
- [ ] 🎨 Style
- [ ] 🧑‍💻 Code Refactor
- [ ] 🔥 Performance Improvements
- [ ] ✅ Test
- [ ] 🤖 Build
- [ ] 🔁 CI
- [ ] 📦 Chore (Release)
- [ ] ⏩ Revert

## Description

<!-- 
Please do not leave this blank 
This PR [adds/removes/fixes/replaces] the [feature/bug/etc]. 
-->
Implement the credential router which is used to navigate the issuing
and verifying request rely on the proof format of the credential

## Related Tickets & Documents
<!-- 
Please use this format link issue numbers: Fixes #123

https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
-->

## Mobile & Desktop Screenshots/Recordings

<!-- Visual changes require screenshots -->


## Added tests?

- [ ] 👍 yes
- [ ] 🙅 no, because they aren't needed
- [ ] 🙋 no, because I need help

## Added to documentation?

- [x] 📜 README.md
- [ ] 📓 [vc-kit doc site](https://uncefact.github.io/vckit/)
- [ ] 📕 storybook
- [ ] 🙅 no documentation needed

## [optional] Are there any post-deployment tasks we need to perform?


<!-- note: PRs with deleted sections will be marked invalid -->

---------

Signed-off-by: Nam Hoang <[email protected]>
  • Loading branch information
namhoang1604 committed Aug 9, 2023
1 parent 59fb8a5 commit c5e9f1c
Show file tree
Hide file tree
Showing 31 changed files with 1,328 additions and 518 deletions.
5 changes: 3 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@
"@vckit/remote-server": "^1.0.0-beta.5",
"@vckit/renderer": "^1.0.0-beta.5",
"@vckit/vc-api": "workspace:1.0.0-beta.5",
"@vckit/revocationlist": "workspace:*",
"@vckit/encrypted-storage": "workspace:*",
"@vckit/revocationlist": "workspace:^",
"@vckit/encrypted-storage": "workspace:^",
"@vckit/credential-router": "workspace:^",
"@veramo/core": "5.2.0",
"@veramo/credential-status": "5.2.0",
"@veramo/credential-eip712": "5.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/credentialOA.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ credentialOA
const proofFormat = 'OpenAttestationMerkleProofSignature2018';

if (identifiers.length === 0) {
console.error('No dids');
console.error('No did ethrs');
process.exit();
}
const answers = await inquirer.prompt([
Expand Down
3 changes: 2 additions & 1 deletion packages/core-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"ICredentialStatusManager": "./src/types/ICredentialStatusManager.ts",
"IRenderer": "./src/types/IRender.ts",
"IEncryptedStorage": "./src/types/IEncryptedStorage.ts",
"IRevocationList2020": "./src/types/IRevocationList2020.ts"
"IRevocationList2020": "./src/types/IRevocationList2020.ts",
"ICredentialRouter": "./src/types/ICredentialRouter.ts"
}
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/core-types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@ export * from './types/IRender.js';
export * from './types/IRendererProvider.js';
export * from './types/IEncryptedStorage.js';
export * from './types/IRevocationList2020.js';
export * from './types/ICredentialRouter.js';
Loading

0 comments on commit c5e9f1c

Please sign in to comment.