fix: removed duplicate test case and implement mock fetch to simulate…

… the case that fetch template from url
uncefact · Jun 12, 2024 · 75c4d42 · 75c4d42
1 parent d4e31b1
commit 75c4d42
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 30 deletions.
diff --git a/packages/renderer/__tests__/providers/render-template-2024.test.ts b/packages/renderer/__tests__/providers/render-template-2024.test.ts
@@ -1,8 +1,6 @@
 import { RenderTemplate2024 } from '../../src/providers/render-template-2024';
 import universityDegreeCredentialTemplate2024 from '../../fixtures/univerisity-degree-credential-template-2024.json';
 import { jest } from '@jest/globals';
-import { IRendererContext } from '@vckit/core-types';
-import { url } from 'inspector';
 
 describe('RenderTemplate2024', () => {
   let renderer: RenderTemplate2024;
@@ -337,33 +335,6 @@ describe('RenderTemplate2024', () => {
     expect(result).toEqual({"renderedTemplate": 'Error: No hash function provided to verify the template'});
   });
 
-  it('should return empty string if it failed to fetch template from url', async () => {
-    const document = { name: 'John Doe', url: 'example.com'};
-    const data = {
-      'https://schema.org/encodingFormat': [
-        {
-          '@value': 'text/html',
-        },
-      ],
-      'https://www.w3.org/2018/credentials#renderMethod#template': [
-        {
-          '@value':
-            '',
-        },
-      ],
-      'https://www.w3.org/2018/credentials#renderMethod#url': [
-        {
-          '@value': 'example.com', // Replace with the actual URL
-        },
-      ],
-    };
-    const result = await renderer.renderCredential({
-      data,
-      document,
-    });
-    expect(result.renderedTemplate).toBe('');
-  });
-
   it('should return template with style added', async () => {
     const document = { name: 'John Doe', url: 'example.com'};
     const data = {
@@ -397,4 +368,27 @@ describe('RenderTemplate2024', () => {
     expect(JSON.stringify(result.renderedTemplate)).toBe("\"<style>@media (min-width: 1024px) {\\n  .title {\\n    font-weight: bold;\\n    color: #223675;\\n  }\\n}</style>\"");
   });
 
+  it('should fetch template from URL and render correctly', async () => {
+    global.fetch = jest.fn() as typeof fetch;
+    const mockTemplate = '<div>{{name}}</div>';
+    (global.fetch as jest.Mock).mockReturnValue({
+      ok: true,
+      text: async () => mockTemplate,
+    });
+
+    const data = {
+      'https://www.w3.org/2018/credentials#renderMethod#url': [{ '@value': 'https://example.com/template' }],
+      'https://schema.org/encodingFormat': [{ '@value': 'text/html' }],
+      'https://schema.org/name': [{ '@value': 'Test Name' }],
+    };
+
+    const result = await renderer.renderCredential({
+      data,
+      document: { name: 'Test Name' },
+    });
+
+    expect(result.renderedTemplate).toBe('<div>Test Name</div>');
+    expect(global.fetch).toHaveBeenCalledWith('https://example.com/template');
+  });
+
 });
diff --git a/packages/renderer/fixtures/univerisity-degree-credential-template-2024.json b/packages/renderer/fixtures/univerisity-degree-credential-template-2024.json
@@ -2,7 +2,12 @@
   "@context": [
     "https://www.w3.org/ns/credentials/v2",
     "https://www.w3.org/ns/credentials/examples/v2",
-    "https://vckit-contexts.s3.ap-southeast-2.amazonaws.com/render-template-context-2024.json"
+    {
+      "ex": "https://www.w3.org/2018/credentials#renderMethod#",
+      "renderMethod": "https://www.w3.org/2018/credentials#renderMethod",
+      "template": "ex:template",
+      "url": "ex:url"
+    }
   ],
   "id": "http://example.edu/credentials/3732",
   "type": ["VerifiableCredential", "UniversityDegreeCredential"],