Enable generation of testnet xPub #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i know this project is not being maintained anymore, but I decided to open this anyway, maybe it will be usefull for someone in the future.
I noticed that
MPCCrypto_serializePubBIP32has all the necessary logic to create test net xPub keys. The regarding functions even have a parameter to control that. But the parameter has a default value and is never changed by calling methods. The exposed functions by the library (insidempc_crypto.h) do not offer a way to pass that information. I just added the parameterbool mainand passed it down toserialize_pubwhich accepted this parameter anyway.(bool main representing wether the xPub is generated for mainnet or not)