Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring what happens if we get rid of the bash entrypoint.
milpa commands of kind
executable
are not fully supported yet, need to figure out:MILPA_(ARG|OPT)_
env vars available, serializingrepeated
values somehow (it should be clear in docs that this is a best-effort, and not as reliable as reading structured input).Bash is great, and it's my main scripting language, so that's not going away. Other shells are great too, and loosening the dependency on bash, while allowing other shells (
zsh
, for now) sounds like a good idea, and something I'd like to play with.fish
? don't use it, but seems cool, and already supported by cobra.itself
commands into golang and remove the dependency onbash
?utils
are bash-only, even if some might work in zsh;log
was ported since it's included by default. Porting and maintaining these for each scripting language that I may wanna include sounds like a lot of work, for something I might not even use. Maybe I should make the runtime pluggable instead?The bash entrypoint is gone, so this will also come into play:
MilpaRoot
/MILPA_ROOT
to be modified somehow when installing brew formula. The formula needs a couple more tweaks.less -FIRX