Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix warning #1807

Merged
merged 4 commits into from
Apr 10, 2025
Merged

chore: fix warning #1807

merged 4 commits into from
Apr 10, 2025

Conversation

elrrrrrrr
Copy link

@elrrrrrrr elrrrrrrr commented Apr 10, 2025 •
edited
Loading

  1. Clean up build warnings for cargo check --bin utoo
  2. Remove redundant and unused variables
  3. Mark temporarily unused properties with dead_code macro
  4. Comment out currently disabled redundant code
  5. Update the ci.yml file to implement incremental CI

@elrrrrrrr elrrrrrrr added the documentation Improvements or additions to documentation label Apr 10, 2025
@elrrrrrrr elrrrrrrr requested review from killagu and xusd320 April 10, 2025 08:15
@elrrrrrrr elrrrrrrr closed this Apr 10, 2025
@elrrrrrrr elrrrrrrr reopened this Apr 10, 2025
killagu
killagu approved these changes Apr 10, 2025
View reviewed changes
Copy link

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elrrrrrrr elrrrrrrr merged commit 8fc97b7 into next Apr 10, 2025
3 checks passed
@elrrrrrrr elrrrrrrr deleted the chore-warning branch April 10, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killagu killagu killagu approved these changes

@xusd320 xusd320 Awaiting requested review from xusd320

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrrrrrrr @killagu