Skip to content

Commit

Permalink
Remove pg revision check
Browse files Browse the repository at this point in the history
  • Loading branch information
ctring committed Aug 4, 2023
1 parent 3ea895d commit 3de9e2e
Showing 1 changed file with 20 additions and 20 deletions.
40 changes: 20 additions & 20 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -189,26 +189,26 @@ jobs:
submodules: true
fetch-depth: 1

- name: Check Postgres submodules revision
shell: bash -euo pipefail {0}
run: |
# This is a temporary solution to ensure that the Postgres submodules revision is correct (i.e. the updated intentionally).
# Eventually it will be replaced by a regression test https://github.com/neondatabase/neon/pull/4603
FAILED=false
for postgres in postgres-v14 postgres-v15; do
expected=$(cat vendor/revisions.json | jq --raw-output '."'"${postgres}"'"')
actual=$(git rev-parse "HEAD:vendor/${postgres}")
if [ "${expected}" != "${actual}" ]; then
echo >&2 "Expected ${postgres} rev to be at '${expected}', but it is at '${actual}'"
FAILED=true
fi
done
if [ "${FAILED}" = "true" ]; then
echo >&2 "Please update vendors/revisions.json if these changes are intentional"
exit 1
fi
# - name: Check Postgres submodules revision
# shell: bash -euo pipefail {0}
# run: |
# # This is a temporary solution to ensure that the Postgres submodules revision is correct (i.e. the updated intentionally).
# # Eventually it will be replaced by a regression test https://github.com/neondatabase/neon/pull/4603

# FAILED=false
# for postgres in postgres-v14 postgres-v15; do
# expected=$(cat vendor/revisions.json | jq --raw-output '."'"${postgres}"'"')
# actual=$(git rev-parse "HEAD:vendor/${postgres}")
# if [ "${expected}" != "${actual}" ]; then
# echo >&2 "Expected ${postgres} rev to be at '${expected}', but it is at '${actual}'"
# FAILED=true
# fi
# done

# if [ "${FAILED}" = "true" ]; then
# echo >&2 "Please update vendors/revisions.json if these changes are intentional"
# exit 1
# fi

- name: Set pg 14 revision for caching
id: pg_v14_rev
Expand Down

0 comments on commit 3de9e2e

Please sign in to comment.